Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129733/
-----------------------------------------------------------

(Updated Jan. 3, 2017, 11:37 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Albert Astals Cid and René J.V. Bertin.


Changes
-------

Submitted with commit 8ff849760a57b3245daef16552f55e48c8c9424d by David Faure to branch master.


Repository: kservice


Description
-------

Symlinks to (desktop) files are still supported.


Diffs
-----

  autotests/ksycocatest.cpp 4564ee6750a80a109492c197c83944e129dcabac 
  src/sycoca/ksycocautils_p.h f144a80ea6d845ed5eaff41689756b30f17d9391 
  src/sycoca/vfolder_menu.cpp 5acbf8ac21a1a0170cee4aa96882bd97eb2a4f2a 

Diff: https://git.reviewboard.kde.org/r/129733/diff/


Testing
-------

Added unittest (which failed before the fix, passes after the fix)


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170103/f7fdd959/attachment.html>