Review Request 129737: [kio] Error when changing target of symlink in plasma folder view

[David Faure]

> On Jan. 1, 2017, 11:02 a.m., David Faure wrote:
> > I'd rather fix KIO::symlink, which is advertised to support Overwrite.
> > 
> > Unittests and fix coming up.
> 
> Chinmoy Ranjan Pradhan wrote:
>     Overwrite in KIO::symlink works fine. It's the 'desktop' protocol that causes the error, so I used KIO::link which resolves desktop: correctly.

I know. It was still a bug in the handling of symlink() for kio_desktop, fixed now in https://commits.kde.org/kio/7f2abde5cb036b8b500aaff45886368ca295e24f
You can discard this workaround.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129737/#review101695
-----------------------------------------------------------


On Jan. 1, 2017, 8:55 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129737/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2017, 8:55 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 360487
>     https://bugs.kde.org/show_bug.cgi?id=360487
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Use CopyJob::link instead of KIO::symlink in kpropertiesdialog when changing target of symlink.
> Fixes the said error (BUG 360487).
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdialog.cpp 50ae563 
> 
> Diff: https://git.reviewboard.kde.org/r/129737/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Error message
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/01/01/b32cbf34-4232-4a7e-9cd7-fe4d30e2fc75__kio_error.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170101/f0e6113d/attachment.html>