[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in CMakeLists.txt:42
> It's easier to add something later than to remove it.
> 
> I'd go with not installing for now, then revisit it. Maybe same for Menus.

ok. what about the combobox?

> davidedmundson wrote in Button.qml:28
> I don't get why we check background here and in other places. It would only be null if a user subclassed this and then overwrote the property to undefined, at which point they deserve errors.

good point

> davidedmundson wrote in Label.qml:27
> I still want this changed.

the reason for the padding is that it makes it correctly vertically aligned with other widgets both in a Row and a RowLayout.
without this default height, every label should be manually vertically centered in layouts, and people will simply not do that, mostly because most people simply won't see the incorrect alignment, not even when explicitly pointed to them.

> davidedmundson wrote in qmldir:11
> Dialog and DialogButtonBox are listed here but aren't installed. I think that will cause an error.
> 
> And do we need CheckIndicator here?

removed.
no, all CheckIndicator,radioindicator and switchindicator are private, used by both the checkbox and checkdelegate, but not intended to be usable publicly

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4508

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170228/37039cbd/attachment.html>