[Differential] [Commented On] D4739: make sure the cancel action is last

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> mart wrote in dropjob.h:38
> used for class KIO::DropMenu : public QMenu in dropjob.cpp,
> doesn't compile otherwise

Not a good enough reason to have it in the public header (which doesn't use it anywhere), you can move that fwd decl to the .cpp file.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D4739

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #frameworks, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170228/0c2869e5/attachment.html>