[Differential] [Updated] D4827: possibility to use a fallback chain as prefix

[Marco Martin]

mart marked an inline comment as done.
mart added a comment.


  In https://phabricator.kde.org/D4827#90599, @davidedmundson wrote:
  
  > > [15:20] ‎<‎notmart‎>‎ if the svg doesn't exists, it falls back to the breeze one
  > > ‎[15:20] ‎<‎notmart‎>‎ then all hasElementPrefix would check if said prefix exists in the breeze theme
  >
  > That's exactly what this code is doing, just in a much more complicated way...
  
  
  no, because buttons.svg would exist in the old theme that does not have the prefix

INLINE COMMENTS

> broulik wrote in framesvgitem.cpp:287
> Maybe print a warning if none found? Or how did the old code behave where we would always call this no matter if we had it?

yeah, it would always do it (and for framesvg setting an inexistent prefix has the effect of setting an empty one)
so perhaps if none found, print a warning and set one (the first, the last, whatever)

> broulik wrote in framesvgitem.cpp:321
> Sure that QML gives you a QStringList?

yep, just works

> broulik wrote in framesvgitem.cpp:438
> I think this loop which is in three places should be turned into a private method void applyPrefixes(const QStringList &prefixes)

ok

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4827

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170227/2c308f2f/attachment-0003.html>