[Differential] [Commented On] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D4797#90144, @broulik wrote:
  
  > > So changing only the theme would mean to change the svg of `ButtonStyle`, which is not desirable.
  >
  > Then we need to introduce new elements in `widgets/button.svg` or a new `widget/toolbutton.svg` for `ToolButton` which is used and falls back to the old behavior if not present (to not break compat with other themes). `QToolButton` is QtWidgets which has nothing to do with QML or Plasma styles.
  
  
  having a new svg would make it easier for fallback (would fallback to breeze toolbutton for old themes) even tough i like the idea of keeping a single svg instead and trying to give some fallback api to framesvgitem

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4797

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, mart
Cc: mart, ltoscano, broulik, hpereiradacosta, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170227/1f3f6451/attachment.html>