[Differential] [Accepted] D4813: Add function to extract a single file

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Looks good, just some nitpicks. Feel free to push directly.

INLINE COMMENTS

> xslt.cpp:365
> +    if (index == -1) {
> +        if (filename == QStringLiteral("index.html")) {
> +            return fromUnicode(content);

QLatin1String would be better (because it's a comparison, and there's a QLatin1String overload for this purpose)

> xslt.cpp:368
> +        } else {
> +            return QByteArray(); // null
> +        }

I like the value added by the comment :-)

> xslt.h:17
>  
> +/*
> + * Extract the content of a single file from the content string

I think doxygen needs /** here, no?

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4813

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, dfaure
Cc: dfaure, #frameworks, #documentation
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170227/7fcce713/attachment.html>