Review Request 127409: Make sure we're not forcing the window to be created prematurely

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127409/#review102600
-----------------------------------------------------------



What's the status of this? Should it be commited? improved? discarded?

- Albert Astals Cid


On March 17, 2016, 2:13 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127409/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 2:13 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Only update the properties that require a winId when visible, otherwise let updateVisibility() take care about them.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp 7bb63c5 
> 
> Diff: https://git.reviewboard.kde.org/r/127409/diff/
> 
> 
> Testing
> -------
> 
> I don't get platform creations being forced on gdb.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170225/da257955/attachment.html>