Review Request 129967: Make KGlobalaccel X11 track XInput events to still work when an application grabs the keyboard

David Edmundson david at davidedmundson.co.uk
Fri Feb 24 16:26:57 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129967/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kglobalaccel


Description
-------

This means shortcuts still work when keyboard is grabbed by another
application. This allows us to still take a screenshot/change volume
with a context menu open.

The existing code doesn't seem to actually handle dynamic keyboard
layout switching, this code matches that behaviour.

Interestingly alt+tab behavior is unchanged so it doesn't /severely/ break
legitimate keyboard grabs like virtualbox.


Diffs
-----

  CMakeLists.txt 0de00d4a6b0700a0c36fe291a8240bea43e62cc2 
  cmake/modules/FindXKB.cmake PRE-CREATION 
  src/runtime/plugins/xcb/CMakeLists.txt 45bf4dc9f9ec9146a0db5f93b4259ea6c4306d17 
  src/runtime/plugins/xcb/kglobalaccel_x11.h 88b7f61e9cfa5e30df7f04f492a864f1ce8eb37a 
  src/runtime/plugins/xcb/kglobalaccel_x11.cpp 9b37c7b600d6f25a0ea43643d8dee2593c3b7417 

Diff: https://git.reviewboard.kde.org/r/129967/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170224/d0d1c8f5/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list