[Differential] [Commented On] D4699: [KTextEditor] Reset filetype when opening url

John Salatas noreply at phabricator.kde.org
Fri Feb 24 07:06:32 UTC 2017


jsalatas added a comment.


  In https://phabricator.kde.org/D4699#89262, @cullmann wrote:
  
  > Don't we need to honor "m_reloading" to avoid to do this on document reloads?
  
  
  `KTextEditor::DocumentPrivate::documentReload()` is keeping m_fileTypeSetByUser to a local variable (`byUser`) before calling `openUrl` and uses that local variable after reloading to set the highlighting mode.
  
  I'll double check however and get back to you

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4699

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #ktexteditor, #frameworks, #framework_syntax_hightlighting, dhaumann
Cc: dhaumann, cullmann, kwrite-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170224/8b5e6b96/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list