[Differential] [Updated] D4716: Add some more directives to MIPS assembler highlighting

[Dominik Haumann]

dhaumann added a comment.


  I think in general a good idea.
  
  Some comments:
  
  - Could you update the patch with the mentioned issues?
  - Could you also provide two test cases (under MIT license) that demonstrate MIPS and GNU Assembler highlighting? That would be very helpful for our unit tests.

INLINE COMMENTS

> c-preprocessor.xml:13-14
> +    section="Other"
> +    extensions="*.c++;*.cxx;*.cpp;*.cc;*.C;*.h;*.hh;*.H;*.h++;*.hxx;*.hpp;*.hcc;*.S"
> +    mimetype="text/x-c++src;text/x-c++hdr;text/x-chdr;text/x-csrc"
> +    author="Alex Richardson (arichardson.kde at gmail.com)"

I would prefer

extensions="" mimetype="" hidden="true" priority="1"

> c-preprocessor.xml:16
> +    author="Alex Richardson (arichardson.kde at gmail.com)"
> +    license="LGPL"
> +    hidden="true"

Are you also ok with MIT license?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D4716

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arichardson, vkrause, dhaumann
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170223/8395d690/attachment.html>