[Differential] [Requested Changes] D4713: Fix binding loop regression in FrameSVGItem

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  i can reproduce kai's problems, luckily the fix seems easy

INLINE COMMENTS

> framesvg.cpp:757
>      fd->theme = q->theme()->d;
> -    updateAndSignalSizes();
> +    if (updateType == UpdateFrameAndMargins) {
> +        updateAndSignalSizes();

in order to restore the behavior before https://phabricator.kde.org/R242:d8a1a9eb084b19e552c789244267f7346e1b27a8
you need to update the sizes anyways in this way (the resize event did that anyways)
otherwise you can get a frame with uninitialized sizes

  if (updateType == UpdateFrameAndMargins) {
      updateAndSignalSizes();
  } else {
      updateSizes(fd);
  }

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4713

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, #frameworks, mart
Cc: mart, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170222/2c58e54d/attachment.html>