[Differential] [Requested Changes] D4619: Printing: Respect footer font, fix footer vertical position, make header/footer separator line visually lighter
Dominik Haumann
noreply at phabricator.kde.org
Tue Feb 21 20:58:47 UTC 2017
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
I tested this patch: I think, the footer's height is not correct when the box is disabled, see: http://i.imgur.com/Te5XigY.png
When the box is activated, it has the same height as the header. I think it should always have the same height.
Could you have a look again?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4619
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: atomsymbol, kfunk, mwolff, dhaumann
Cc: dhaumann, kwrite-devel, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170221/a2a3f22a/attachment.html>
More information about the Kde-frameworks-devel
mailing list