[Differential] [Request, 1 line] D4688: [FrameSvgItemMargins] Don't update on repaintNeeded

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Feb 20 15:47:12 UTC 2017


broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  FrameSvgItem already updates the margins in response to that.

TEST PLAN
  `FrameSvgItem` has
  
    connect(m_frameSvg, SIGNAL(repaintNeeded()), this, SLOT(doUpdate()));
  
  and in doUpdate does
  
    m_margins->update();
    m_fixedMargins->update();
  
  I still get tons of binding loop warnings on e.g. "topMargin" in Plasma

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4688

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, drosca
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170220/42adf769/attachment.html>


More information about the Kde-frameworks-devel mailing list