Exporting KFilePlaceEditDialog

Elvis Angelaccio elvis.angelaccio at kde.org
Sun Feb 19 12:02:24 UTC 2017


Hi,
currently KFilePlaceEditDialog is not exported by kfilewidgets. As I
understand it, it's supposed to be used only through KFilePlacesView
(that's what gwenview and konqueror do).

However, Dolphin is using its own implementation of
KFilePlacesModel/KFilePlacesView. This is why Dolphin has its own
dialog to edit places, which is exactly the same as
KFilePlaceEditDialog but with more bugs, e.g. see [1].

Could we make KFilePlaceEditDialog a public class? I don't really see
downsides in doing this. We reduce code duplication (by killing the
buggy Dolphin dialog) and Dolphin can still use its own model/view
places stuff (I tested it localy and seems to work).

Cheers,
Elvis

[1]: https://bugs.kde.org/show_bug.cgi?id=376619


More information about the Kde-frameworks-devel mailing list