Review Request 129921: [kio-extras] thumbnails should be a clean image representation without "hard-coded" borders or design elements

[Diego Soenens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129921/
-----------------------------------------------------------

(Updated Feb. 18, 2017, 10:52 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit db7f8d0c945880b0fbb5ea9ad8ed6817d6ba0340 by David Faure on behalf of Diego Soenens to branch Applications/16.12.


Repository: kio-extras


Description
-------

This patch is part of https://git.reviewboard.kde.org/r/129918/ - see the discussion on the old patch https://git.reviewboard.kde.org/r/118961/.

Many thumbnail generators currently return ThumbCreator::DrawFrame in their flags() function which causes a 90's style 1px "3d" border to be added to the thumbnail image.
This causes problems when consumers of these thumbnails (like Dolphin) expect a clean image representation of the file, without hard-coded design elements.
It also looks really bad when any resizing/scaling happens or when the thumbnail is shown on a tooltip. Especially now that the UI has been modernized with Breeze.


Diffs
-----

  thumbnail/comiccreator.cpp d8f4473e1c7fa4595ad8defc406ad945d1ac38ac 
  thumbnail/djvucreator.cpp 1547831bfaa875a14a59659a2bebc86a2cd7c024 
  thumbnail/htmlcreator.cpp 29d1902794abfa3cf8ba2ab97648e1bc2d8e7a73 
  thumbnail/kritacreator.cpp 3b24bc3d2fa7b22662c25da1421cbd542d7efed6 
  thumbnail/textcreator.cpp 7c0263c8e8cb4f88d1429b5714c51c2939d817f0 

Diff: https://git.reviewboard.kde.org/r/129921/diff/


Testing
-------

Builds.


Thanks,

Diego Soenens

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170218/cfc5e2d2/attachment.html>