[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

[Martin Gräßlin]

graesslin added a comment.


  This is a sensible idea, though I wonder whether we should put it into something more concrete than a QProperty on the qApp.

INLINE COMMENTS

> kcolorscheme.h:33-37
> +KSharedConfigPtr defaultConfig() {
> +    // Read from the application's color scheme file (as set by KColorSchemeManager).
> +    // If unset, this is equivalent to openConfig() and the system scheme is used.
> +    return KSharedConfig::openConfig(qApp->property("KDE_COLOR_SCHEME_PATH").toString());
> +}

in case the kcolorscheme.h gets installed, I suggest to not inline the method.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D4637

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, #frameworks
Cc: graesslin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170217/7e3d63ea/attachment.html>