Review Request 129955: fix off by one in the socket filename
Damjan Georgievski
gdamjan at gmail.com
Thu Feb 16 23:50:37 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129955/
-----------------------------------------------------------
(Updated Feb. 17, 2017, 1:50 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
-------
Submitted with commit fa1fbc2568fdfcf3f6ffa7370c3d26a3a47b9a5e by Aleix Pol on behalf of Damjan Georgievski to branch Plasma/5.9.
Repository: kwallet-pam
Description
-------
from the snprintf man page:
The functions snprintf() and vsnprintf() do not write more than size bytes (*including* the terminating null byte ('\0')). If
the output was truncated due to this limit, then the return value is the number of characters (*excluding* the terminating null
byte) which would have been written to the final string if enough space had been available. Thus, a return value of size or
more means that the output was truncated.
pam_wallet.c should increase the needed parameter by one, to account for the terminating null byte ('\0')
Diffs
-----
pam_kwallet.c c89bf6d
Diff: https://git.reviewboard.kde.org/r/129955/diff/
Testing
-------
Thanks,
Damjan Georgievski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170216/e488c599/attachment.html>
More information about the Kde-frameworks-devel
mailing list