[Differential] [Commented On] D4620: allow to add application actions on an open menu

[Eike Hein]

hein added a comment.


  Much nicer than the other approach, just one question.

INLINE COMMENTS

> dropjob.cpp:324
> +    for (QMenu *menu : d->m_menus) {
> +        if (!d->m_appActions.isEmpty() || !d->m_pluginActions.isEmpty()) {
> +            menu->addSeparator();

Should this be && instead of ||? "Add actions if either of those is not empty" seems weird, what's the reasoning?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D4620

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: hein, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170215/cf206c7b/attachment.html>