[Differential] [Commented On] D4537: EditorConfig support

[Christoph Cullmann]

cullmann added a comment.


  Ok, then I would opt for removing the comment.
  
  Beside that, I think in some places early outs would be preferable to nesting, e.g. like
  
  if (code != 0) {
  
    if (code == EDITORCONFIG_PARSE_MEMORY_ERROR) {
  
  ​        qCDebug(LOG_KTE) << "Failed to parse .editorconfig, memory error occurred";
  
    else
  
  ​        qCDebug(LOG_KTE) << "Failed to parse .editorconfig, unknown error";
  
    return code;
  
  }
  
  then the rest non-indented

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4537

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: gszymaszek, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170214/c1f0dde4/attachment.html>