[Differential] [Request, 3 lines] D4496: Don't use KConfig keys with backslashes

Elvis Angelaccio noreply at phabricator.kde.org
Wed Feb 8 11:43:11 UTC 2017


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: aacid.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Kile has ambiguous shortcuts which result in the following string used
  as KConfig key for the dontShowAgain KMessageBox checkbox:
  
  `Find in Files...Normal Fraction - \frac{}{}Alt+Shift+F`
  
  However KConfig doesn't like it:
  
  "Invalid escape sequence \"\\f\"."
  
  and the 'f' character after the slash is removed from the key, breaking the
  dontShowAgain functionality.
  
  This patch removes all backslashes from the key, before passing it to
  the messagebox.

TEST PLAN
  Open Kile, check the dontShowAgain checkbox, close Kile. Open again Kile and
  make sure the messagebox is not shown again.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4496

AFFECTED FILES
  src/kxmlguiwindow.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, aacid
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170208/4ccb955f/attachment.html>


More information about the Kde-frameworks-devel mailing list