[Differential] [Request, 2 lines] D4471: Fix KCModule::setAuthAction error checking

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  The current code checks if the existing action is valid rather the
  argument; and if it is invalid does an early return. That means you
  can't ever properly set a valid action.

TEST PLAN
  Started clock KCM which uses this, confirmed we got no warning

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4471

AFFECTED FILES
  src/kcmodule.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170207/6dfe8a8e/attachment.html>