[Differential] [Commented On] D4439: KDirWatch: fix memory leak on destruction.

[David Faure]

dfaure added a comment.


  QScopedPointer wouldn't work here (this isn't about a scope). std::unique_ptr would most certainly work, but then again, why use pointers where values can work. I like Albert's approach overall, with only the two concerns I listed.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4439

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, mpyne, aacid
Cc: markg, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170205/840ff758/attachment.html>