Review Request 129911: Added property() method to TerminalInterface class

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129911/#review102401
-----------------------------------------------------------



Alas, this is a binary incompatible change. It cannot be done this way.
Solution 1: a V2 interface inheriting from this one (as we had in the past, IIRC).
Solution 2: just use QObject dynamic properties, after documenting that in this header file.

- David Faure


On Feb. 3, 2017, 5:23 p.m., Sven Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129911/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2017, 5:23 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kparts
> 
> 
> Description
> -------
> 
> For konsole KPart consumers it may be necessary to access the properties
> of the konsole profile, e.g. the "Start in current session dir" to be
> able to control the working directory in new KPart instantiation.
> 
> A corresponding patch has been submitted to the konsole repository.
> 
> 
> Diffs
> -----
> 
>   src/kde_terminal_interface.h f9603d120d5116db35ae60d65b2743a5aceaebac 
> 
> Diff: https://git.reviewboard.kde.org/r/129911/diff/
> 
> 
> Testing
> -------
> 
> Locally compile konsole against this changed header, and running a yakuake instance against the patched konsole.
> 
> 
> Thanks,
> 
> Sven Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170205/a6b78237/attachment-0001.html>