Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129798/#review102399
-----------------------------------------------------------


Ship it!




Patch looks ok to me, although I don't know much about all this.

The real problem isn't tooling, but lack of active maintainership for kfilemetadata. Are you interested in taking over?

- David Faure


On Jan. 15, 2017, 3:03 p.m., Matthieu Gallien wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129798/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2017, 3:03 p.m.)
> 
> 
> Review request for Baloo and KDE Frameworks.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> -------
> 
> Musepack extraction of album artist was using the wrong tag name (tested
> against easytag and picard).
> 
> See also this page (http://taglib.org/api/classTagLib_1_1APE_1_1Tag.html) that seems to indicate that APE is using "ALBUM ARTIST" with a space between both words.
> 
> 
> Diffs
> -----
> 
>   autotests/samplefiles/test.flac PRE-CREATION 
>   autotests/samplefiles/test.m4a PRE-CREATION 
>   autotests/samplefiles/test.mp3 PRE-CREATION 
>   autotests/samplefiles/test.mpc PRE-CREATION 
>   autotests/samplefiles/test.ogg PRE-CREATION 
>   autotests/taglibextractortest.cpp d46e49e 
>   src/extractors/taglibextractor.cpp 8fcad93 
> 
> Diff: https://git.reviewboard.kde.org/r/129798/diff/
> 
> 
> Testing
> -------
> 
> I have tested with automatic tests of KFileMetaData and also the encoding problem in Musepack format against Easytag and Picard applications.
> 
> 
> Thanks,
> 
> Matthieu Gallien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170205/9e5a31d8/attachment.html>