Differential commit log keyword is uncomfortable - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

Albert Astals Cid aacid at kde.org
Sat Feb 4 17:30:16 UTC 2017


El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure:
> Hi everyone,
> 
> We've just completed the registration of all mainline repositories
> (not including Websites or Sysadmin namespaced ones) on Phabricator.
> Thanks go to Luigi Toscano for providing significant assistance with
> this process.
> 
> From this point forward, communities should be moving away from
> Reviewboard to Phabricator for conducting code review.

https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

Differential Revision: https://phabricator.kde.org/D<number>

can we get something much shorter like

DIFFERENTIAL: D<number>
or even
DIFFERENTIAL: <number>
?

I guess making both work should not be hard.

The fact that you have to write "Differential Revision:" vs REVIEW: CCMAIL: BUG: etc is quite "strange"

Also neededing to include the full url is not very comfortable when writing.

Does anyone have love for the current syntax?

Cheers,
  Albert


More information about the Kde-frameworks-devel mailing list