[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7
Albert Astals Cid
noreply at phabricator.kde.org
Sat Feb 4 16:05:23 UTC 2017
aacid added a comment.
In https://phabricator.kde.org/D4422#82977, @dfaure wrote:
> So your patch adds a member variable which duplicates QIODevice::d->devicePos, but there's no other solution without adding more API to QIODevice.
>
> I deem QIODevice API incomplete, and your patch correct given the circumstances.
Yeah, one can use the _p.h header that exposes devicePos but i thought depending on the private implementation wasn't cool.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D4422
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: aacid, dfaure
Cc: dfaure, anthonyfieroni, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170204/84570006/attachment.html>
More information about the Kde-frameworks-devel
mailing list