[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

Albert Astals Cid noreply at phabricator.kde.org
Fri Feb 3 13:17:12 UTC 2017


aacid added a comment.


  In https://phabricator.kde.org/D4422#82875, @anthonyfieroni wrote:
  
  > I understand code, it will work now, but to me it's a workaround.
  
  
  Why is it a workaround?
  
  > What about to call QIODevice::seek(0) in constructor, other unchanged to original code ?
  
  Please, test stuff before suggesting it, saying "No" to every random thing you think may work is not fun.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D4422

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aacid
Cc: anthonyfieroni, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170203/dd44d5e5/attachment.html>


More information about the Kde-frameworks-devel mailing list