Review Request 129849: KToolTipWidget: don't take ownership of the content widget

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129849/
-----------------------------------------------------------

(Updated Feb. 2, 2017, 11:16 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Feck.


Changes
-------

Submitted with commit 26b1ec257ab38c56e69803e96de695af2773024c by Elvis Angelaccio to branch master.


Repository: kwidgetsaddons


Description
-------

While the layout of the tooltip sets the tooltip as parent of the content widget, we don't really need to take ownership of it. We can just restore the old parent once we are done.
This prevents a double delete crash if someone (by accident) deletes first the tooltip and then the content.


Diffs
-----

  autotests/ktooltipwidgettest.h 556d93edd7792736bb7b41761f2d8934395d2f3c 
  autotests/ktooltipwidgettest.cpp 89124c6b3f16b76a346a8c9c74ff2f9efe0c9e83 
  src/ktooltipwidget.h cde7e66af797c9888dec59ef50831a2260a2c238 
  src/ktooltipwidget.cpp 544eb74d005bb4c963c8cc6cd8b941c018cf463e 

Diff: https://git.reviewboard.kde.org/r/129849/diff/


Testing
-------

Test case reproduces the crash, which is fixed by the patch.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170202/4ff68966/attachment.html>