[Differential] [Request, 23 lines] D4405: [KFilePreviewGenerator] Add ignoreMaximumSize

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Feb 2 14:39:55 UTC 2017


broulik created this revision.
broulik added reviewers: dfaure, emmanuelp, hein.
broulik set the repository for this revision to R241 KIO.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This allows a user of this class to set the ignoreMaximumSize flag in the PreviewJobs used.

TEST PLAN
  Dolphin has a logic where it will always ignore the maximum size for local files (isLocalFile or protocolClass == ":local"). This doesn't work in FolderView which uses this class to generate previews for its files.
  
  The question on the other hand is whether we should just adopt this policy globally in PreviewJob itself instead.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D4405

AFFECTED FILES
  src/filewidgets/kfilepreviewgenerator.cpp
  src/filewidgets/kfilepreviewgenerator.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, dfaure, emmanuelp, hein
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170202/c63cd0fe/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list