[Differential] [Updated] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide

[Dominik Haumann]

dhaumann added a comment.


  First of all a general note: Unfortunately, we have had quite some issues with getting the geometry right in KMessageWidget over the past few years. Essentially, the problem is that KMessageWidgets animates its show and hide events, and therefore caches its initial and its final geometry, as well as the pixmap to render to avoid stretching the KMessageWidget's contents. That said, doing this caching too early results in a final geometry that is wrong (we had this issue in Kate a lot).
  
  This may sound a bit off-topic, but the point is: it's easy to break things. If you in addition also run the unit test 'messagetest' of KTextEditor and if it passes, then I'm fine with this change. It looks reasonable after all :-)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D4329

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks, dhaumann
Cc: cfeck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170202/830ecdec/attachment.html>