[Differential] [Changed Subscribers] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide
Christoph Feck
noreply at phabricator.kde.org
Thu Feb 2 00:44:36 UTC 2017
cfeck added inline comments.
INLINE COMMENTS
> kmessagewidgetautotest.cpp:24
> #include <QtTest/QtTest>
> +#include <QSignalSpy>
> #include <kmessagewidget.h>
Isn't QSignalSpy part of QtTest? In other words, isn't it included by above #include line?
> kmessagewidgetautotest.cpp:125
> + w.animatedShow();
> + if (delay) QTest::qWait(overlappingWaitingTime);
> + w.animatedHide();
if (delay) {
QTest::bla;
}
> kmessagewidgetautotest.cpp:158
> + w.animatedHide();
> + if (delay) QTest::qWait(overlappingWaitingTime);
> + w.animatedShow();
s.a.
> kmessagewidgetautotest.cpp:189
> + w.animatedShow();
> + if (delay) QTest::qWait(overlappingWaitingTime);
> + w.animatedShow();
s.a.
> kmessagewidgetautotest.cpp:218
> + w.animatedHide();
> + if (delay) QTest::qWait(overlappingWaitingTime);
> + w.animatedHide();
s.a.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D4329
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, #frameworks, dhaumann
Cc: cfeck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170202/ba2ed620/attachment.html>
More information about the Kde-frameworks-devel
mailing list