[Differential] [Request, 8 lines] D4392: Fix KEditListWidget losing the focus on click of Add button
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Wed Feb 1 12:33:27 UTC 2017
kossebau created this revision.
kossebau added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
When the user triggers the Add button by keyboard focus or mouse,
the button has focus when it gets disabled in the addItem() handler.
Which results in the focus being passed on, to whatever next widget
in the tab focus order(?) can get focus. Inside KEditListWidget
these are the other buttons, which are usually disabled when an
item is added, so the focus is moved out of the KEditListWidget.
Which usually makes no sense, as the user may want to do more actions
on the list, until explicitly leaving the scene.
TEST PLAN
Usages of KListEditWidget in KDevelop's "New from Template..." dialog,
e.g. in the test cases of class data pages, no longer are frustrating,
as no longer will the focus move to the "Back" dialog button after
clicking "Add".
REPOSITORY
R236 KWidgetsAddons
BRANCH
makeKListEditWidgetNotLoseFocus
REVISION DETAIL
https://phabricator.kde.org/D4392
AFFECTED FILES
src/keditlistwidget.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170201/756a0523/attachment.html>
More information about the Kde-frameworks-devel
mailing list