D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> kprocesstest.cpp:47
>      p.setProcessChannelMode(QProcess::MergedChannels);
> -    p.start(gargv[0], QStringList() << QString::number(how) << QStringLiteral("--nocrashhandler"));
> +    p.start(QString::fromLatin1(gargv[0]), QStringList() << QString::number(how) << QString::fromLatin1("--nocrashhandler"));
>      p.waitForFinished();

nocrashhandler why do you changed as QString::fromLatin1 ? it's QStringList() so it can work no ?

> kshelltest.cpp:167
>  
> -    const QString unicodeSpaceFileName = "test　テスト.txt"; // #345140
> +    const QString unicodeSpaceFileName = QLatin1String("test　テスト.txt"); // #345140
>      QCOMPARE(sj(unicodeSpaceFileName, KShell::AbortOnMeta | KShell::TildeExpand, &err),

QLAtin1String for japan char ?

> velurimithun wrote in kstringhandlertest.cpp:45
> Here char i. e., (' ') is converted into string i.e., (" ") and then QLatin1String is applied.
> 
> Since, we can't convert char into QLatin1String

QLatin1Char(' ') ?

> kstringhandlertest.cpp:49
>      expected.clear();
> -    expected << "Split" << "me" << "up ! I'm bored ! OK ?";
> -    QCOMPARE(KStringHandler::perlSplit(QRegExp("[! ]"), "Split me up ! I'm bored ! OK ?", 3), expected);
> +    expected << QLatin1String("Split") << QLatin1String("me") << QLatin1String("up ! I'm bored ! OK ?");
> +    QCOMPARE(KStringHandler::perlSplit(QRegExp(QLatin1String("[! ]")),

QStringLiteral no ?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9420

To: velurimithun, mlaurent
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171230/d42ff97f/attachment-0001.html>