D8536: Add more hashing algorithms to KPropertiesDialog

Peter Majchrak noreply at phabricator.kde.org
Wed Dec 27 10:04:10 UTC 2017


petermajchrak added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kpropertiesdialog.cpp:3015
> Mutex is not needed here.

This function is called from the QtConcurrent mapper function and therefore can be called concurrently by more threads. QMap::insert is not thread safe for concurrent write operations as far as I know.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8536

To: petermajchrak, elvisangelaccio, #vdg, colomar
Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171227/3377c4d6/attachment.html>


More information about the Kde-frameworks-devel mailing list