D9491: Sonnet: fix wrong language for suggestions in mixed-language texts

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> dfaure wrote in highlighter.h:134
> The -1 special value is documented here, but yeah, special values are bad.
> 
> In practice SpellCheckDecorator calls this with the default value anyway.
> 
> And I guess any GUI will always want to limit this, you don't really want to offer 300 suggestions to the user...
> 
> So maybe we could remove the -1 special value (in the new method) anyway.

Of course I am aware of that - that's why I wrote this is rather unrelated to your patch (or let's say it is in accordance with the existing API).

I don't request any changes here, so if at all, you could add a 
// TODO: KF6: all values <= 0 will not truncate the suggestion list.

Please push :-)

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9491

To: dfaure, sandsmark, mlaurent, dhaumann
Cc: dhaumann, #kde_pim, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171224/b9d77e70/attachment.html>