D9494: Highlighting indexer: Warn about empty attributes
Dominik Haumann
noreply at phabricator.kde.org
Sat Dec 23 21:20:45 UTC 2017
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch extends the highlighting indexer to search for
attribute="". Referencing an empty attribute is most likely
an error.
In fact, this check finds one issue, and one false positive.
Still, it's better to fix it properly to ensure conformance.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
CheckEmptyAttribute (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9494
AFFECTED FILES
data/syntax/d.xml
data/syntax/puppet.xml
src/indexer/katehighlightingindexer.cpp
To: dhaumann, vkrause
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171223/109affd9/attachment.html>
More information about the Kde-frameworks-devel
mailing list