D9493: Highlighting indexer: Warn about context switch fallthroughContext="#stay"

Dominik Haumann noreply at phabricator.kde.org
Sat Dec 23 21:06:04 UTC 2017


dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  A fallthroughContext="#stay" is always wrong if fallthrough="true" is set,
  since in this case we risk an infinite loop. This patch extends the indexer
  to check for this mistakes. Luckily, this mistake does not exist in the
  definition files shipped with the KSyntaxHighlighting framework.

TEST PLAN
  make test, manual testing with fallthroughContext="#stay"

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  InvalidFallthroughContext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9493

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: dhaumann, vkrause, cullmann
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171223/fcc2df1b/attachment.html>


More information about the Kde-frameworks-devel mailing list