D9332: Allow filter places based on alternative application name

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> kfileplacesmodeltest.cpp:145
> +    KFilePlacesModel *currentModel = model;
> +    if (currentModel == nullptr) {
> +        currentModel = m_places;

`if (!currentModel)` ?

> kfileplacesmodel.h:69
> +    /**
> +    * @brief Construct a new KFilePlacesModel with a alternativeApplicationName
> +    * @param alternativeApplicationName This value will be used to filter bookmarks in addition of the actual application name

typo: an alternativeApplicationName

> kfileplacesmodel.h:70
> +    * @brief Construct a new KFilePlacesModel with a alternativeApplicationName
> +    * @param alternativeApplicationName This value will be used to filter bookmarks in addition of the actual application name
> +    * @param parent Parent object

wording: "in addition to" sound better to me

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9332

To: renatoo, mwolff, mlaurent
Cc: elvisangelaccio, mlaurent, aacid, ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171223/9136e052/attachment.html>