D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> KF5DBusAddonsMacros.cmake:4
> +#
> +# kdbusaddons_generate_dbus_service_file(executable name path)
> +#

kdbusaddons_generate_dbus_service_file(EXECUTABLE NAME PATH) to improve the readability.

Please also document each parameter.

> KF5DBusAddonsMacros.cmake:6
> +#
> +# This function generates a dbus service file and installs it
> +# into the specified destination.

D-Bus

> KF5DBusAddonsMacros.cmake:9
> +#
> +# On Windows the path is not used because dbus service executables
> +# are always installed in the same directory as dbus-daemon.

D-Bus

> KF5DBusAddonsMacros.cmake:14
> +#
> +#  kdbusaddons_generate_dbus_service_file(kded5 org.kde.kded5 ${CMAKE_INSTALL_PATH}/bin)
> +#

${KDE_INSTALL_FULL_BINDIR}

> KF5DBusAddonsMacros.cmake:23
> +    else()
> +        set(EXEC ${_path}/${_executable})
> +    endif()

You don't check whether _path is absolute. This shall return an error.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D9480

To: habacker, dfaure, kfunk
Cc: cgiboudeaux, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171222/d427fde7/attachment-0001.html>