D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

Ralf Habacker noreply at phabricator.kde.org
Fri Dec 22 10:13:38 UTC 2017


habacker added a comment.


  In https://phabricator.kde.org/D9423#182022, @habacker wrote:
  
  > 1. install dbus service file
  
  
  installing the service file requires a KDE specific path, ${KDE_INSTALL_DBUSSERVICEDIR}, so a KF5 related name seems to be more descriptive
  
    function(kf5_generate_dbus_service_file _executable _name _path)
      set(_file ${CMAKE_CURRENT_BINARY_DIR}/${_name}.service)
      set(_template ${CMAKE_CURRENT_LIST_FILE}/KF5DBusServiceTemplate.in)
      set(NAME ${_name})
      if(WIN32)
          set(EXEC ${_executable})
      else()
          set(EXEC ${_path}/${_executable})
      endif()
      configure_file(${_template} ${_file})
      install(FILES ${_file} DESTINATION ${KDE_INSTALL_DBUSSERVICEDIR})
    endfunction()
  
  where KF5DBusServiceTemplate.in looks as
  
    [D-BUS Service]
    Name=@NAME@
    Exec=@EXEC@
  
  and may be better located in the kdbusaddons repo  instead of extra-cmake-modules ? What is prefered ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9423

To: habacker, dfaure, bcooksley, kfunk
Cc: apol, kfunk, broulik, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171222/8a3bc562/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list