D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

[Ralf Habacker]

habacker added a comment.


  In https://phabricator.kde.org/D9423#181793, @dfaure wrote:
  
  > A single .in file sounds good indeed. Sorry for approving the first one too fast.
  
  
  That means the solution needs to be applied to more then one git repo
  
  - kio
  - kwallet
  - just recgonized that kded is also affected (https://cgit.kde.org/kded.git/tree/src/org.kde.kded5.service.in)
  
  Would it then not be better to create and use an ecm function  for that ?
  
  e.g  something like
  
  function(ECM_GENERATE_DBUS_SERVICE_FILE  target)
  
  1. detect platform
  2. if windows
  3. set empty path
  4. else
  5. get target install location
  6. endif
  7. generate dbus service file from template contained in ecm packages or using raw write
  8. install dbus service file
  
  endfunction()
  
  where 'target' - is the cmake target name
  
  e.g.
  
  ecm_generate_dbus_service_file(kded)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9423

To: habacker, dfaure, bcooksley, kfunk
Cc: apol, kfunk, broulik, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171221/4e8f15f0/attachment.html>