D9423: Fix 'Exec line in kiod service file must not have any path prefix on Windows'

[Ralf Habacker]

habacker added a comment.


  In https://phabricator.kde.org/D9423#181574, @kfunk wrote:
  
  > In https://phabricator.kde.org/D9423#181460, @habacker wrote:
  >
  > > In https://phabricator.kde.org/D9423#181442, @kfunk wrote:
  > >
  > > > And I agree. There shouldn't be a need to use two different input files. That's the whole point of `configure_file(...)`: the interpolation of values happens *inside* the input files.
  > >
  > >
  > > This would be possible by using in the service file something like this
  > >
  > > [D-BUS Service]
  > >  Name=org.kde.kiod5
  > >  Exec=@SOME_PREFIX at kiod5
  >
  >
  > Sounds good.
  >
  > In the top-level CMakeLists.txt maybe:
  >
  >   if(WIN32)
  >        set(DBUS_LIBEXECDIR)
  >   else()
  >        set(DBUS_LIBEXECDIR ${KDE_INSTALL_FULL_LIBEXECDIR}/kf5/)
  >   endif()
  >
  
  
  The service template will then look like 
  [D-BUS Service]
  Name=org.kde.kioexecd
  Exec=@DBUS_LIBEXECDIR at kiod5
  
  just saw that for kcookiejar5 another variable is required and the above mentioned cmake fragment needs to be extended to
  
    if(WIN32)
       set(DBUS_LIBEXECDIR)
       set(DBUS_BINDIR)
    else()
       set(DBUS_LIBEXECDIR ${KDE_INSTALL_FULL_LIBEXECDIR}/kf5/)
       set(DBUS_BINDIR ${CMAKE_INSTALL_PREFIX}/bin/)
    endif()
  
  and src/ioslaves/http/kcookiejar/org.kde.kcookiejar5.service.in looks like shown below
  [D-BUS Service]
  Name=org.kde.kcookiejar5
  Exec=@DBUS_BINDIR at kded5

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9423

To: habacker, dfaure, bcooksley, kfunk
Cc: apol, kfunk, broulik, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171220/a6ae04d4/attachment.html>