D9290: [kio] Fix create path
David Faure
noreply at phabricator.kde.org
Wed Dec 20 10:36:34 UTC 2017
dfaure added inline comments.
INLINE COMMENTS
> dfaure wrote in pathhelpers_p.h:31
> It seems to me that path2 cannot start with '/', by contract. It's supposed to be relative.
> So I'd say we could even be foolish^H^H^H^Hbrave and make that
>
> Q_ASSERT(!path2.startsWith('/'));
The assert hits during KDirModelTest, says CI. Can you take a look?
QFATAL : KDirModelTest::testRenameDirectory() ASSERT: "!path2.startsWith(QLatin1Char('/'))" in file /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.10/src/core/../pathhelpers_p.h, line 31
https://build.kde.org/view/Frameworks/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/39/testReport/(root)/TestSuite/kiowidgets_kdirmodeltest/
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9290
To: anthonyfieroni, #frameworks, dfaure, hein, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171220/cf10fb45/attachment.html>
More information about the Kde-frameworks-devel
mailing list