D9399: Fix crash, presumably since Qt 5.10?

Anthony Fieroni noreply at phabricator.kde.org
Tue Dec 19 05:52:19 UTC 2017


anthonyfieroni added inline comments.

INLINE COMMENTS

> apol wrote in http.cpp:4910
> Why seek if this is essentially the same?
> Actually, initialising the qbytearray and opening a stream over it then skipping its contents feels wrong.

Current implementation has a 4k buffer on the stack (from Qt source), patched one exclusive copy, seek is faster and cleaner.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9399

To: apol, #frameworks, dfaure
Cc: anthonyfieroni, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171219/886f9252/attachment.html>


More information about the Kde-frameworks-devel mailing list