D9393: MessageInterface: Add CenterInView as additional position
Dominik Haumann
noreply at phabricator.kde.org
Mon Dec 18 10:50:43 UTC 2017
dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch extends the message interface to support CenterInView.
This should be binary compatible, since an enum is only added at
the end. In order to support this, a custom layout called
KateMessageLayout was added that only supports the floating
positions allowed by KTextEditor::Message::MessagePosition.
Upadte unit test, it seems the window size was too small for
the MessageTest.
TEST PLAN
make test
REPOSITORY
R39 KTextEditor
BRANCH
MessageInterface (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9393
AFFECTED FILES
autotests/src/kateview_test.cpp
src/include/ktexteditor/message.h
src/view/kateview.cpp
src/view/kateview.h
src/view/kateviewhelpers.cpp
src/view/kateviewhelpers.h
src/view/kateviewinternal.cpp
To: dhaumann, cullmann
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171218/1875c609/attachment.html>
More information about the Kde-frameworks-devel
mailing list