D9369: XML (Debug): Fix incorrect DetectChar rule

Dominik Haumann noreply at phabricator.kde.org
Sun Dec 17 11:52:06 UTC 2017


dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  The fix is to simply remove the parts of the char that were
  ignored anyways. Whether this is the correct patch is up for
  discussion - but since noone complained for years, this is
  possibly not a big issue anyways. And: the XML (Debug) file
  does not have any extension nor mimetype, so we can safely
  say essentially noone is using this...
  
  Fixes:
  checkSingleChars: xmldebug.xml" line 130 'char' must contain exactly one char: "\"(\\s+|$)"
  checkSingleChars: xmldebug.xml" line 135 'char' must contain exactly one char: "'(\\s+|$)"
  checkSingleChars: xmldebug.xml" line 374 'char' must contain exactly one char: "\"(\\s+|$)"
  checkSingleChars: xmldebug.xml" line 379 'char' must contain exactly one char: "'(\\s+|$)"
  checkSingleChars: xmldebug.xml" line 416 'char' must contain exactly one char: "\"(\\s+|$)"
  checkSingleChars: xmldebug.xml" line 421 'char' must contain exactly one char: "'(\\s+|$)"
  checkSingleChars: xmldebug.xml" line 468 'char' must contain exactly one char: "\"(\\s+|$)"
  checkSingleChars: xmldebug.xml" line 473 'char' must contain exactly one char: "'(\\s+|$)"

TEST PLAN
  make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  FixXmlDebug (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9369

AFFECTED FILES
  data/syntax/xmldebug.xml

To: dhaumann, vkrause
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171217/f85ac385/attachment.html>


More information about the Kde-frameworks-devel mailing list