D9361: Highlighting Indexer: Support cross-hl context checking

Dominik Haumann noreply at phabricator.kde.org
Sat Dec 16 18:32:31 UTC 2017


dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Previously, context references of the form "Comment##C++" were ignored.
  With this patch, context cross language references are correctly taken
  into account. As result, we can now detect unused contexts correctly
  in all cases. To make this work, the ContextChecker had to be moved
  to before the loop over all hl files.
  
  As result, the GNU Macros are now not showing up as false positive
  anymore.

TEST PLAN
  make && make test, manual testing

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  FixIncludeRulesCheck (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9361

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: dhaumann, vkrause
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171216/2dfb7f31/attachment.html>


More information about the Kde-frameworks-devel mailing list