D9330: Fix cmake warning (with cmake >= 3.9.0)

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Thu Dec 14 15:24:07 UTC 2017


kossebau added a comment.


  In https://phabricator.kde.org/D9330#179506, @dfaure wrote:
  
  > Why not do this in ECM?
  
  
  Doing this in ECM would mean maintaining a list of macros in a repo/product separate from the repo/products where the respective macros are defined. More, what libraries should ECM cover? Just KF5 ones? What about macros from libs from kde apps, extragear etc.
  
  It scales better, is better to maintain and feels also more logic to have each module's cmake config inject any needed extension of CMAKE_AUTOMOC_MACRO_NAMES into the build of products linking and picking up any such cpp macros. That's what cmake config is for, configuring and providing things as needed with a dep :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9330

To: mlaurent, dfaure
Cc: kossebau, flherne, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171214/b0a9b434/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list