D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes
Kevin Funk
noreply at phabricator.kde.org
Wed Dec 13 10:45:50 UTC 2017
kfunk added a comment.
In https://phabricator.kde.org/D9299#179036, @cgiboudeaux wrote:
> In https://phabricator.kde.org/D9299#179035, @cgiboudeaux wrote:
>
> > In https://phabricator.kde.org/D9299#179032, @kfunk wrote:
> >
> > > If we'd name this file somewhat less generic then it could be even installed by default, no?
> > >
> > > I had the scheme of the QNX setup script in my mind: https://github.com/acklinr/qnx660/blob/master/qnx660-env.sh
> > >
> > > Thus: Maybe rename prefix.sh to say 'ecm-env.sh' and install the file by default?
> >
> >
> > Files overwritting each others is a no-go for packagers. +1 for a less generic name however.
>
>
> Adding files in /usr directly, will also be rejected.
>
> Now that I had a closer look: KDEInstallDirs only defines some paths, I don't think this change shall be part of this file. What about moving it to its own file and sourcing it instead ?
I agree. KDEInstallDirs.cmake seems to be wrong location for this functionality.
What I'm envisioning is a ecm-env.sh-like script which gets installed into `$PREFIX/bin` as soon as you install ECM.
Pseudo-cmake code:
configure_file(${CMAKE_SOURCE_DIR}/ecm-env.sh ${CMAKE_BINARY_DIR}/ecm-env.sh)
install(FILES ${CMAKE_BINARY_DIR}/ecm-env.sh DESTINATION ${BIN_INSTALL_DIR})
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9299
To: apol, #frameworks, sitter
Cc: kfunk, bcooksley, ngraham, sitter, cgiboudeaux, #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171213/c7be258d/attachment.html>
More information about the Kde-frameworks-devel
mailing list